daniel/concon
1
0
Fork 0
Code Issues 8 Pull requests 2 Projects Releases Packages Wiki Activity Actions

#003: Add concon:targetDataset support for federated entity search #15

Open
asit wants to merge 1 commit from issue/003-federated-entity-search into main
pull from: issue/003-federated-entity-search
merge into: daniel:main
Conversation 0 Commits 1 Files changed 2 +107 -3
asit commented 2026-04-30 12:43:06 +00:00
Collaborator
Copy link

Closes #3

What

Adds support for concon:targetDataset in SHACL property shapes,
allowing sh:class autocomplete to search a different dataset
instead of the current one.

Changes

src/shacl.rs

  • Added target_dataset: Option<String> field to PropertyField struct
  • Extended SPARQL query in parse_property_shapes to read
    concon:targetDataset from property shapes
  • New test: test_parse_target_dataset_extension

src/routes/datasets.rs

  • Added target_dataset: Option<String> to SearchParams
  • /_api/search now searches the target dataset when specified;
    returns [] silently if the target dataset doesn't exist
  • New tests: test_search_in_target_dataset,
    test_search_target_dataset_not_found_returns_empty

Pending

  • JS update in entity_editor.html to pass target_dataset
    in autocomplete requests (to be added before merge)

Tests

49 passing, 0 failing

Closes #3 ## What Adds support for `concon:targetDataset` in SHACL property shapes, allowing `sh:class` autocomplete to search a different dataset instead of the current one. ## Changes **`src/shacl.rs`** - Added `target_dataset: Option<String>` field to `PropertyField` struct - Extended SPARQL query in `parse_property_shapes` to read `concon:targetDataset` from property shapes - New test: `test_parse_target_dataset_extension` **`src/routes/datasets.rs`** - Added `target_dataset: Option<String>` to `SearchParams` - `/_api/search` now searches the target dataset when specified; returns `[]` silently if the target dataset doesn't exist - New tests: `test_search_in_target_dataset`, `test_search_target_dataset_not_found_returns_empty` ## Pending - JS update in `entity_editor.html` to pass `target_dataset` in autocomplete requests (to be added before merge) ## Tests 49 passing, 0 failing
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin issue/003-federated-entity-search:issue/003-federated-entity-search
git switch issue/003-federated-entity-search

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff issue/003-federated-entity-search
git switch issue/003-federated-entity-search
git rebase main
git switch main
git merge --ff-only issue/003-federated-entity-search
git switch issue/003-federated-entity-search
git rebase main
git switch main
git merge --no-ff issue/003-federated-entity-search
git switch main
git merge --squash issue/003-federated-entity-search
git switch main
git merge --ff-only issue/003-federated-entity-search
git switch main
git merge issue/003-federated-entity-search
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
daniel/concon!15
No description provided.